Re: display slabs in cpu partial list for slub

[qiaonuohan <qiaonuohan@xxxxxxxxxxxxxx>]

On 07/24/2014 12:26 AM, Dave Anderson wrote:
> ----- Original Message -----
> > Why not display it like all of the other per-cpu items, e.g.,
> > showing something like this:
> >
> >    CACHE            NAME                 OBJSIZE  ALLOCATED     TOTAL  SLABS
> >    SSIZE
> >    ffff8800370b2500 tw_sock_TCPv6            200          0         0      0
> >    8k
> >    CPU 0 KMEM_CACHE_CPU
> >    ffff88021fc18890
> >    CPU 0 SLAB:
> >      (empty)
> >    CPU 0 PARTIAL:
> >      (empty)
> >    CPU 1 KMEM_CACHE_CPU
> >    ffff88021fc58890
> >    CPU 1 SLAB:
> >      (empty)
> >    CPU 1 PARTIAL:
> >      (empty)
> >    CPU 2 KMEM_CACHE_CPU
> >    ffff88021fc98890
> >    CPU 2 SLAB:
> >      (empty)
> >    CPU 2 PARTIAL:
> >      (empty)

I see your style is more clear. Do you need me respin the patch?

> Or better yet, to make it even more clear, indent the kmem_cache_cpu address like
> contents of the other per-cpu items:
>
>    CACHE            NAME                 OBJSIZE  ALLOCATED     TOTAL  SLABS  SSIZE
>    ffff8800370b2500 tw_sock_TCPv6            200          0         0      0     8k
>    CPU 0 KMEM_CACHE_CPU
>      ffff88021fc18890
>    CPU 0 SLAB:
>      (empty)
>    CPU 0 PARTIAL:
>      (empty)
>    CPU 1 KMEM_CACHE_CPU
>      ffff88021fc58890
>    CPU 1 SLAB:
>      (empty)
>    CPU 1 PARTIAL:
>      (empty)
>    CPU 2 KMEM_CACHE_CPU
>      ffff88021fc98890
>    CPU 2 SLAB:
>      (empty)
>    CPU 2 PARTIAL:
>      (empty)
>
> Dave
>
>
> --
> Crash-utility mailing list
> Crash-utility@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/crash-utility


--
Regards
Qiao Nuohan

--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/crash-utility