Hi
On Thu, Aug 22, 2013 at 12:32 PM, Dave Anderson <anderson@xxxxxxxxxx> wrote:
>
>
> ----- Original Message -----
>> Hi
>>
>> On Thu, Aug 22, 2013 at 8:44 AM, Anatol Pomozov
>> <anatol.pomozov@xxxxxxxxx> wrote:
>> > The scructure was renamed from gate_struct to gate_desc in 2.6.25 kernel
>> >
>> > Tested: works on 3.11 dump
>> > ---
>> > x86_64.c | 7 ++++++-
>> > 1 file changed, 6 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/x86_64.c b/x86_64.c
>> > index 4264bae..3e2d5b4 100755
>> > --- a/x86_64.c
>> > +++ b/x86_64.c
>> > @@ -298,7 +298,12 @@ x86_64_init(int when)
>> > machdep->machspec->modules_end =
>> > MODULES_END_2_6_31;
>> > }
>> > STRUCT_SIZE_INIT(cpuinfo_x86, "cpuinfo_x86");
>> > - STRUCT_SIZE_INIT(gate_struct, "gate_struct");
>> > + if (STRUCT_EXISTS("gate_desc")) {
>> > + STRUCT_SIZE_INIT(gate_struct, "gate_desc");
>> It probably worth to rename 'gate_struct' variable to 'gate_desc' as well.
>
> Yeah, but there's almost 800 offset table members stored as it is -- if I kept
> adding new ones for each kernel name change, it would add a few hundred more,
> and for little benefit. Anyway, it's the command output that's important.
Should we at least change user-visible string in
symbols.c:9163: fprintf(fp, " gate_struct: %ld\n",
>
> Thanks for resurrecting this option. Queued for crash-7.0.2
>
> Dave
>
>>
>> > + } else {
>> > + // before 2.6.25 the structure called gate_struct
>> > + STRUCT_SIZE_INIT(gate_struct, "gate_struct");
>> > + }
>> > STRUCT_SIZE_INIT(e820map, "e820map");
>> > STRUCT_SIZE_INIT(e820entry, "e820entry");
>> > MEMBER_OFFSET_INIT(e820map_nr_map, "e820map", "nr_map");
>> > --
>> > 1.8.3
>> >
>>
--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/crash-utility
