----- Original Message ----- > Hello Dave, > > It's done. I use *NOW* to replace *OFFSET*. Please check. crash> timer -r cpu: 0 HRTIMER_CPU_BASE: ffff88021e20e700 clock: 0 HRTIMER_CLOCK_BASE: ffff88021e20e740 NOW: 92474883 GET_TIME: ktime_get EXPIRES HRTIMER FUNCTION 92475257224621-92475257274621 ffff880210d63eb8 ffffffff81085fc0 <hrtimer_wakeup> 92475337818743-92475338341742 ffff88020f1a9a68 ffffffff81085fc0 <hrtimer_wakeup> 92475708000000-92475708000000 ffff88021e20e960 ffffffff810b62a0 <tick_sched_timer> 92476040000000-92476040000000 ffff88021e20eae0 ffffffff810eb3e0 <watchdog_timer_fn> 92480244973869-92480245023869 ffff88021184beb8 ffffffff81085fc0 <hrtimer_wakeup> 92497170944250-92497200944249 ffff880210f05a68 ffffffff81085fc0 <hrtimer_wakeup> 92499263103403-92499293079402 ffff880211a19da8 ffffffff81085fc0 <hrtimer_wakeup> 93626419371172-93626419371172 ffff88020f97b7b8 ffffffff810654e0 <it_real_fn> 93626560930229-93626560930229 ffff88020f97d578 ffffffff810654e0 <it_real_fn> 94865820026579-94865920026579 ffff88020e365da8 ffffffff81085fc0 <hrtimer_wakeup> Shouldn't the NOW value for the ktime_get timers be adjusted appropriate to the EXPIRES values? Dave > > At 2013-3-6 22:56, Dave Anderson wrote: > > > > > > ----- Original Message ----- > >> Hello Dave, > >> > >> Sorry for late. And I think my last mail is not that clear, so I > >> will > >> add some explanation here. > >> > >> And firstly, some answers to your question. > >> > >> 1. offset means the offset of the clock to the monotonic time. > >> > >> 2. If offset is 0 or without offset, the clock gets the monotonic > >> time > >> with it. > >> > >> 3. If offset is not 0, lick clock 0 on cpu 0, the time of this > >> clock is > >> monotonic time together with the value of offset. Additionally, > >> expiration of the clock is also based on the offset. > >> > >> If I want to compare expiration with current time, I should first > >> add > >> offset with monotonic time(I use uptime in my command, for > >> accurate time > >> is unable to get), then get the current time of the clock. > > > > Right, so what I was saying is that it doesn't make much sense to > > show "OFFSET: 0", and it's also confusing when nothing is shown on > > the older versions. > > > > Perhaps there could be a "NOW:" field, where you come up with > > per-timer-type algorithms to show a value that relates to the > > expires value? > > > > And while you're at it, can you please remove the "HRTIMER_BASES[]" > > and also clean up the unnecessary accessible() calls? > > > > Thanks, > > Dave > > > > -- > > Crash-utility mailing list > > Crash-utility@xxxxxxxxxx > > https://www.redhat.com/mailman/listinfo/crash-utility > > > > > > > -- > -- > Regards > Qiao Nuohan > > > > -- > Crash-utility mailing list > Crash-utility@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/crash-utility -- Crash-utility mailing list Crash-utility@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/crash-utility