Re: [PATCH] Add -r option to timer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




----- Original Message -----
> Hello Dave,
> 
> Sorry for late. And I think my last mail is not that clear, so I will
> add some explanation here.
> 
> And firstly, some answers to your question.
> 
> 1. offset means the offset of the clock to the monotonic time.
> 
> 2. If offset is 0 or without offset, the clock gets the monotonic time
> with it.
> 
> 3. If offset is not 0, lick clock 0 on cpu 0, the time of this clock is
> monotonic time together with the value of offset. Additionally,
> expiration of the clock is also based on the offset.
> 
> If I want to compare expiration with current time, I should first add
> offset with monotonic time(I use uptime in my command, for accurate time
> is unable to get), then get the current time of the clock.

Right, so what I was saying is that it doesn't make much sense to 
show "OFFSET: 0", and it's also confusing when nothing is shown on
the older versions.  

Perhaps there could be a "NOW:" field, where you come up with 
per-timer-type algorithms to show a value that relates to the
expires value?

And while you're at it, can you please remove the "HRTIMER_BASES[]"
and also clean up the unnecessary accessible() calls? 

Thanks,
  Dave

--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/crash-utility


[Index of Archives]     [Fedora Development]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]

 

Powered by Linux