Re: [PATCH] Add -r option to timer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




----- Original Message -----

> Anyway, for consistency with other crash commands, I think that it's
> more useful to display the hrtimer_cpu_base and hr_clock_base structure
> addresses, and perhaps the most important fields within them, in tabular
> form, grouped together something like:
>
>  crash> timer -r
>  CPU: 0
>   CLOCK: 0
>   HRTIMER_CPU_BASE  HR_CLOCK_BASE   OFFSET     FUNCTION
>     <address>         <address>     <value>    ktime_get
>             EXPIRES                 HRTIMER           FUNCTION    
>    396384243603-396384293603    ffff88003c905eb8  ffffffff8107da00  <hrtimer_wakeup>
>    397000645784-397004641782    ffff88003d2b1a58  ffffffff8107da00  <hrtimer_wakeup>
>    407501746988-407531746986    ffff88003c2b5a58  ffffffff8107da00  <hrtimer_wakeup>
>    446387171280-446446754509    ffff88003bb43908  ffffffff8107da00  <hrtimer_wakeup>
>    900000001418-900000001418    ffff8800368e53c0  ffffffff811c57d0  <timerfd_tmrproc>

Actually, since the HRTIMER_CPU_CASE address display would 
be redundant, perhaps something like this would be cleaner:

 crash> timer -r
 CPU: 0  HRTIMER_CPU_BASE: <address>
  CLOCK: 0  HR_CLOCK_BASE: <address>
   OFFSET     FUNCTION
   <value>    ktime_get
            EXPIRES                 HRTIMER           FUNCTION
   396384243603-396384293603    ffff88003c905eb8  ffffffff8107da00  <hrtimer_wakeup>
   397000645784-397004641782    ffff88003d2b1a58  ffffffff8107da00  <hrtimer_wakeup>
   407501746988-407531746986    ffff88003c2b5a58  ffffffff8107da00  <hrtimer_wakeup>
   446387171280-446446754509    ffff88003bb43908  ffffffff8107da00  <hrtimer_wakeup>
   900000001418-900000001418    ffff8800368e53c0  ffffffff811c57d0  <timerfd_tmrproc>

  CLOCK: 1  HR_CLOCK_BASE: <address>
  ...

Dave

--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/crash-utility


[Index of Archives]     [Fedora Development]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]

 

Powered by Linux