On Tue, Jan 29, 2013 at 3:46 PM, Dave Anderson <anderson@xxxxxxxxxx> wrote: > > > ----- Original Message ----- >> Hi, >> >> For x86, crash avoids storing any '__crc_*' symbols. It should do the >> same for ARM, right? Credit goes to Rabin Vincent for this patch, >> unless you don't like it, in which case you can blame me. > > I suppose. It was more of a clutter-reducer than anything else in > the case of x86. But I do note that the __crc_ symbols come after > "_end" in one of the sample ARM dumpfiles I've got on hand. > Clutter reduction is the reason for both of these patches as well and even if the __crc_'s are ignored we'll still get _end+<offset> printouts for everything in the range [_end, 0xff0a81a8]. Of course, a patch for PRRR shouldn't break 'mod -s'. Here's an alternative patch. /Per > Anyway, I don't have a problem with the patch. Mika? > > Dave > > -- > Crash-utility mailing list > Crash-utility@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/crash-utility
diff --git a/arm.c b/arm.c index a46f779..dcff374 100644 --- a/arm.c +++ b/arm.c @@ -611,6 +611,9 @@ arm_verify_symbol(const char *name, ulong value, char type) if (STREQ(name, "$a") || STREQ(name, "$n") || STREQ(name, "$d")) return FALSE; + if (STREQ(name, "PRRR") || STREQ(name, "NMRR")) + return FALSE; + if ((type == 'A') && STRNEQ(name, "__crc_")) return FALSE;
-- Crash-utility mailing list Crash-utility@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/crash-utility
