[PATCH]: another double free in trace extension

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Very similar to the double free I came across earlier this year. No
need to free cpu_buffer->pages in ftrace_init_pages() since
ftrace_destroy_buffers() will free it if ftrace_init_pages() returns <
0.

Regards,
Per
diff --git a/extensions/trace.c b/extensions/trace.c
index 3c33f3c..e6513f9 100644
--- a/extensions/trace.c
+++ b/extensions/trace.c
@@ -250,7 +250,6 @@ static int ftrace_init_pages(struct ring_buffer_per_cpu *cpu_buffer,
 
 	cpu_buffer->linear_pages = calloc(sizeof(ulong), nr_pages + 1);
 	if (cpu_buffer->linear_pages == NULL) {
-		free(cpu_buffer->pages);
 		return -1;
 	}
 
--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/crash-utility

[Index of Archives]     [Fedora Development]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]

 

Powered by Linux