Hi Luc, please consider the attached patch for inclusion in eppic. The actual name should match the name from eppic_api.h. The crash extension worked previously only because the it relied on implicit declaration of the wrong name, which is ugly. Regards, Petr Tesarik
commit 6bac980310b91f6b4c2fdf5954bec7b77674db9a Author: Petr Tesarik <petr@xxxxxxxxxxx> Date: Fri Dec 7 12:53:23 2012 +0100 Rename eppic_typeislocal in the library The actual name should match the name from eppic_api.h. This worked previously only because the eppic crash module used an implicit declaration, which is ugly. Signed-off-by: Petr Tesarik <ptesarik@xxxxxxx> diff --git a/applications/crash/eppic.c b/applications/crash/eppic.c index dde3f6a..984b764 100644 --- a/applications/crash/eppic.c +++ b/applications/crash/eppic.c @@ -476,7 +476,7 @@ apigetval(char *name, ull *val, VALUE_S *value) eppic_setmemaddr(value, *val); eppic_do_deref(1, value, value); *val=eppic_getval(value); - if(!eppic_typeislocal(stype) && eppic_type_getidx(stype) > 100) { + if(!eppic_type_islocal(stype) && eppic_type_getidx(stype) > 100) { char *tname; type=(struct type*)((long)eppic_type_getidx(stype)); if(type->main_type) tname=type->main_type->tag_name; diff --git a/libeppic/eppic_api.c b/libeppic/eppic_api.c index 4b14ee4..3de9b7d 100644 --- a/libeppic/eppic_api.c +++ b/libeppic/eppic_api.c @@ -35,7 +35,7 @@ static stinfo_t slist={"root"}; static ull nextidx=0, abitype=ABI_MIPS; #define LOCALTYPESBASE 0x8000000000000000ll static ull eppic_nextidx(void) { return LOCALTYPESBASE+nextidx++; } -int eppic_typeislocal(type_t *t) +int eppic_type_islocal(type_t *t) { return ((t->idx & LOCALTYPESBASE) != 0); }
-- Crash-utility mailing list Crash-utility@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/crash-utility