From: qiaonuohan <qiaonuohan@xxxxxxxxxxxxxx> Subject: Re: [PATCH] add support to "virsh dump-guest-memory"(qemu memory dump) Date: Tue, 21 Aug 2012 14:05:25 +0800 >>From c2f4d203d1610213ce2af9754d857f7f2192f121 Mon Sep 17 00:00:00 2001 > From: qiaonuohan <qiaonuohan@xxxxxxxxxxxxxx> > Date: Tue, 21 Aug 2012 13:35:54 +0800 > Subject: [PATCH 2/3] support core dump file when kdump is operating > > diff --git a/main.c b/main.c > index 9dced6e..033bfa1 100755 > --- a/main.c > +++ b/main.c > @@ -640,6 +640,8 @@ main_loop(void) > if (!(pc->flags & GDB_INIT)) { > gdb_session_init(); > show_untrusted_files(); > + if (pc->flags2 & QEMU_MEM_DUMP) > + qemu_mem_dump_kdump_backup_region_init(); > if (SADUMP_DUMPFILE()) > sadump_kdump_backup_region_init(); > if (XEN_HYPER_MODE()) { This is different from what Dave suggests. He suggests it's useful if this conversion is applied also to Xen part. Now the conversion is done for vmcore with qemu note only. The previous patch sets QEMU_MEM_DUMP if QEMU note exists. To identify Xen's vmcore, some kind of the sign that indicates "this vmcore is Xen's" is needed. I'm now thinking that this backup region processing should be written commonly among crash dump mechanisms running independently of kdump. They are now qemu's dump-guest-memory, xen's dump mechanism and sadump. Thanks. HATAYAMA, Daisuke -- Crash-utility mailing list Crash-utility@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/crash-utility