Re: timeout in eppic.mk

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, Jul 19, 2012 at 2:47 PM, Dave Anderson <anderson@xxxxxxxxxx> wrote:
>
>
> ----- Original Message -----
>> Different network topologies/setups will have different failure modes.
>> If you want to dig into this I would suggest getting a network capture
>> (tcpdump -s0) at the time of the problem so we can see exactly at what
>> level it is timing out. That said I am not sure the crash build
>> scripts should really have to deal with this kind of things.
>
> Right -- I think I'll just leave it as is (i.e. without -W), and let
> it timeout based upon the host machine's setup.  It's not that big a
> deal, and Jan was happy enough with his 10-second timeout vs. the
> annoying 10-minute git command timeout.
>
> Dave
>

Here's an alternative patch for your consideration, which makes it
possible to point to e.g. a local eppic git.

It also builds ARM with '-m32'. This change is not enough to achieve
that however. Similar tweaks are needed in eppic itself.

Regards,
Per
diff --git a/extensions/eppic.mk b/extensions/eppic.mk
index 5fec0ce..2e1d328 100644
--- a/extensions/eppic.mk
+++ b/extensions/eppic.mk
@@ -12,11 +12,16 @@
 ifeq ($(TARGET), PPC64)
         TARGET_FLAGS = -D$(TARGET) -m64
 else
+ifeq ($(TARGET), ARM)
+        TARGET_FLAGS = -D$(TARGET) -m32
+else
         TARGET_FLAGS = -D$(TARGET)
 endif
+endif
 
 CRASH_REF_ROOT=
 APPFILE=eppic/applications/crash/eppic.c
+GOOGLE := $(shell ping -c 1 code.google.com | grep "1 received")
 
 all:
 	@if [ -f /usr/bin/flex ] && [ -f /usr/bin/bison ]; then \
@@ -26,7 +31,13 @@ all:
         then \
 	      if [ -f /usr/bin/git ]; \
           then \
-             git clone https://code.google.com/p/eppic eppic; \
+            if [ -n "$(EPPIC_GIT_URL)" ]; then \
+	      git clone $(EPPIC_GIT_URL) eppic; \
+            else \
+              if [ -n "$(GOOGLE)" ] ; then \
+	        git clone https://code.google.com/p/eppic eppic; \
+              fi; \
+            fi; \
           else \
 	         echo "eppic.so: git command is needed for pulling eppic extension code"; \
           fi; \
--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/crash-utility

[Index of Archives]     [Fedora Development]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]

 

Powered by Linux