Re: [PATCH] add -t option for runq command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




----- Original Message -----
> Hi Dave,
>
> I agree with your opinion,the first suggestion (1) seems better.I
> have already accepted
> your specification and modified the patch. Specific modification as
> follows:
>
> (1)    The option “-t” is accepted, while the option "-c" was
> abandoned.
> (2)    Turn key word '*_clock' into '*_timestamp'.
> (3)    Add information about active task on each cpu,like this:
> CPU 0: 67393251944103
> [67393251944103]  PID: 14776  TASK: ea54aab0  COMMAND: "crash"
> CPU 1: 66789719628339
> [67393251858710]  PID: 14769  TASK: f4bdc030  COMMAND: "crash"
>
> Do you have any other suggestion or requirement?

No, that's fine.

I did make a slight change to the output display so that the task's
timestamp value is directly under the cpu's value and without the
brackets, making a comparison much easier.  I also re-worded the help
page description, and added the display of the new rq_timestamp offset
value in dump_offset_table().

The patch is queued for crash-6.0.7.

Thanks,
  Dave

--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/crash-utility



[Index of Archives]     [Fedora Development]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]

 

Powered by Linux