From: qiaonuohan <qiaonuohan@xxxxxxxxxxxxxx> Subject: Re: Adding a new command rbtree Date: Thu, 10 May 2012 10:06:25 +0800 > At 2012-5-10 9:31, HATAYAMA Daisuke wrote: >> From: qiaonuohan<qiaonuohan@xxxxxxxxxxxxxx> >> Subject: Adding a new command rbtree >> Date: Wed, 09 May 2012 16:47:58 +0800 > Hello HATAYAMA, > > Hmm, your idea seems not that good to me. As you said, it needs to > search the tree to get the information of position one by one. It will > waste time and effort. But you inspired me. Take look at the following > style. > > crash> rbtree ... > NODE addr1 > ... > NODE addr2 > ... > NODE addr3 > ... > NODE addr4 > ... > NODE addr5 > ... > NODE addr6 > ... > > crash> rbtree -p ... > NODE addr1 > (position information) > ... > NODE addr2 > (position information) > ... > NODE addr3 > (position information) > ... > NODE addr4 > (position information) > ... > NODE addr5 > (position information) > ... > NODE addr6 > (position information) > ... > > -p option will make the command to output position information. > It seems better to me. Just one more thing: "NODE" is obvious and seems not necessary. Thanks. HATAYAMA, Daisuke -- Crash-utility mailing list Crash-utility@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/crash-utility
