Re: Patch to add comments

["Olivier Daudel" <olivier.daudel@xxxxxxxxxxxx>]

Sorry, but just after sending the patch with bash style comments "#", i was 
thinking we could also have c style comments wiht "//". In that way, we may 
choose comment style when we use colored syntax for crash.
Thanks.

--------------------------------------------------
From: "Dave Anderson" <anderson@xxxxxxxxxx>
Sent: Tuesday, April 10, 2012 4:44 PM
To: "Discussion list for crash utility usage,maintenance and development" 
<crash-utility@xxxxxxxxxx>
Subject: Re:  Patch to add comments

> ----- Original Message -----
> > Dave Anderson <anderson@xxxxxxxxxx> a écrit :
> >
> > >
> > >
> > > ----- Original Message -----
> > >>
> > >>
> > >> Hello Dave,
> > >> A small cosmetic pach to add comments in the crash flow.
> > >> Of course we may use !# to do this, but to call a shell just for a
> > >> comment seems rather hard ?
> > >
> > > True -- but your patch that makes "#" an actual command is
> > > way-overkill.
> > >
> > > Why not do this:
> > >
> > > --- main.c      20 Mar 2012 18:11:46 -0000      1.130
> > > +++ main.c      10 Apr 2012 13:59:45 -0000
> > > @@ -768,6 +768,9 @@ exec_command(void)
> > >         if (is_datatype_command())
> > >                 goto reattempt;
> > >
> > > +       if (STRNEQ(args[0], "#"))
> > > +               return;
> > > +
> > >        if (!(pc->flags & MINIMAL_MODE) &&
> > >            is_gdb_command(TRUE, FAULT_ON_ERROR))
> > >                goto reattempt;
> > >
> > > Dave
> > >
> > >
> > >
> > > --
> > > Crash-utility mailing list
> > > Crash-utility@xxxxxxxxxx
> > > https://www.redhat.com/mailman/listinfo/crash-utility
> > >
> > Thanks, simple is better!
> > Nevertheless, do we keep something in the help file or do we just
> > "know" the way to push comment ?
> > Olivier
>
> A line should probably be added to the "help input" page,
> which is the input_info[] string array in help.c.
>
> Dave
>
>
>
> --
> Crash-utility mailing list
> Crash-utility@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/crash-utility

Attachment: comment2.patch
Description: Binary data

--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/crash-utility