----- Original Message ----- ... > > It would be preferable if you could support all 2.6-era kernels, but if not, > the command should handle them more gracefully by pre-verifying the offsets > before using them, and if they are invalid, then use the option_not_supported() > routine. I should note that I *only* tested the "ipcs" command entered alone. Anyway, I now see that you separated the shared memory display into two options, -m and -M. I don't believe that is necessary -- the first patch that you posted gave enough basic information. If you want to expand it, perhaps the extra data that is shown by "-M" option could be included in the "-i id" output? And for that matter, the -u data could also be contained in the "-i id" output? That way the basic shared memory data could be shown by "ipcs [-m]" option, and a fully-exploded display could be done by the "-i id" qualifier because it wouldn't have to be restricted to one line. I also wish you had followed my original suggestion and made this into an extension module first. If you do that, you could just post a single "ipcs.c" command that could be dropped into the "extensions" subdirectory, and built with "make extensions". There has not been a new command added to the crash utility in many years, and it's going to be difficult to accept this as a built-in command until it first goes through a lot of testing, usage, improvement, etc. If it were an extension module, it could be stored on the extensions web page immediately for people to use and test. Also, if you are not going to support the earlier 2.6-era kernels, then the command_not_supported() function would be preferable to option_not_supported(). Thanks, Dave -- Crash-utility mailing list Crash-utility@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/crash-utility
