Re: [PATCH] add option -E for foreach

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




----- Original Message -----
> 
> 
> ----- Original Message -----
> > 
> > 
> > ----- Original Message -----
> > > Hello Dave,
> > > 
> > > I have modified my patch. In my opinion, regular expression should not
> > > mix with other task-identifying arguments, so I made some more modifications
> > 
> > Why not?  It would be far more useful if you could maintain
> > the current capability of providing a mixture of pid/task/name
> > task-identifiers along with this new regular-expression-matching
> > scheme.
> > 
> > Dave
> 
> In fact, I've just reworked (and simplified) your patch so that a
> 'regex' task identifier may be used in conjunction with the other
> task identifier types, make the capability much more useful.
> 
> In fact, it could be modified even further to allow multiple
> regular expression arguments to be allowed, by maintaining
> an regex_t array the same way as it's done for the other
> supported task identifiers.  I'll try that...
> 
> Dave

Done!  With that capability, this a pretty powerful task-identifier.
Thanks for getting the ball rolling -- queued for crash-6.0.5.

Thanks,
  Dave


--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/crash-utility


[Index of Archives]     [Fedora Development]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]

 

Powered by Linux