(2012/02/22 2:14), Dave Anderson wrote: > > > ----- Original Message ----- >> The following series implements : >> >> * An infrastructure for platform based vmalloc translation for PPC32 >> * vmalloc translation support for PPC44x >> >> Changes since V3: >> >> * Use platform specific 'page flags' >> * Avoid calling dump_mem_map() by checking if there is a page >> associated >> with the physical memory. (Suggested by: Dave) >> >> Changes since V2: >> >> * Rebased to crash-6.0.3 >> * Maintains a list of probe functions, rather than platform >> definitions. >> >> >> Each platform can define their own probe_function which would get the name of the >> ppc platform (read from kernel) and the probe can check if it is one of its variant. >> The probe function can then update the 'platform' defintions for the virtual address >> translation. >> >> If none of the defined platforms match, we fall back to using the default PPC32 >> definitions. > > Hi Suzuki, > > With the updated patch #2 addressing Toshi's concerns, the patch-set looks > and tests OK -- for me anyway. > > One thing I will add is the translation of the PAE and CPU_BOOKE flag bits > in ppc_dump_machdep_table(), so that you'll see: > > crash> help -m > platform: ppc440gp > flags: 808001 (KSYMS_START|PAE|CPU_BOOKE) > kvbase: c0000000 > identity_map_base: c0000000 > ... > > Presuming that Toshi is OK with the updated patch #2, consider the patch-set > queued for crash-6.0.4. Hi Dave, As a matter of course, I can entirely agree with Suzuki's ppc improvements and in addition, thanks for your ppc utilities. I'm sure, these are wonderful release candidates! Thanks a lot, Toshi -- Crash-utility mailing list Crash-utility@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/crash-utility
