Re: [PATCH V3] Add -C option for search

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




----- Original Message -----
> Hello Dave,
> 
> The new patch is attached.
> 
> I  simplified the display_with_pre_and_post() function by calling the
> currently-existing display_memory() function, and made the output
> readable according to your advice.
> 
> Thanks
> Zhang Yanfei
> 

It's looking pretty good -- a couple minor points/questions:

(1) in display_memory(), why re-initialize the error_handle each
    time through the loop, instead of doing it just once?
(2) in display_memory(), shouldn't the "lost" variable be reset 
    to 0 after a line of output is printed?

Dave

--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/crash-utility


[Index of Archives]     [Fedora Development]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]

 

Powered by Linux