----- Original Message ----- > > That all being said, your patch does have merit -- presuming that > the meminfo.cache field *never* gets set elsewhere prior to entering > the dump_kmem_cache_xxx functions. I haven't taken the time to > verify that -- did you absolutely verify that? It looks OK to use "if (si->cache)" in those 3 locations -- but it would be safer to create/set a unique meminfo->flags bit for this feature. Dave -- Crash-utility mailing list Crash-utility@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/crash-utility