Re: [PATCH 1/1] CFS runqueue loop detection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/01/2012 02:34 PM, Dave Anderson wrote:

----- Original Message -----

----- Original Message -----
Here is a patch against crash v6.0.2 that adds duplicate node detection
per-CPU for the CFS runqueue display in dump_CFS_runqueues() for the
runq command.

This resolves the failure to bail-out of the unending looping display I
get with the crash dump I have that has a corrupted CFS runqueue
containing a loop.

Signed-off-by: David Mair<dmair@xxxxxxxx>
---
That was quick!

I'm going to have to re-work this patch slightly because of the queued
changes for crash-6.0.3 that are based upon Daisuke's runq patch:

    [PATCH] runq: search current task's runqueue explicitly
   https://www.redhat.com/archives/crash-utility/2012-January/msg00009.html

Dave,

On second thought, I'd rather have you update your patch accordingly, and
then test with your dumpfile to make sure it works as planned.

Can you do this:

   $ wget http://people.redhat.com/anderson/crash.tar.gz

Then go into any top-level crash utility source directory, and do this:

   $ tar xvzmf /path/to/crash.tar.gz

which will overwrite everything -- just "make" to rebuild with all
the queued crash-6.0.3 changes to date.

Then re-do your patch to task.c, test it, and re-post it.

Dave,

I've got a patch prepared but I can't test it until my morning tomorrow (02/02) so I'll post it then. I'm sorry for the delay.

--
David Mair
SUSE Linux

--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/crash-utility


[Index of Archives]     [Fedora Development]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]

 

Powered by Linux