On വ്യാഴം 19 ജനുവരി 2012 03:31 രാവിലെ, Dave Anderson wrote:
----- Original Message -----
These patches are based on crash-6.0.2 + PPC32 KDUMP support patches.
---
Suzuki K. Poulose (2):
[ppc] Backtrace support for active tasks
[ppc] Compressed KDUMP support for PPC32
diskdump.c | 59
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
netdump.c | 2 ++
ppc.c | 13 +++++++++++--
3 files changed, 71 insertions(+), 3 deletions(-)
Before submitting a patch, please always first build it with "make warn",
and then fix them all:
Sorry for that. I will make sure I pass the make warn before I send something.
cc -c -g -DPPC -m32 -D_FILE_OFFSET_BITS=64 -fPIC -DGDB_7_3_1 ppc.c -Wall -O2 -Wstrict-prototypes -Wmissing-prototypes -fstack-protector
ppc.c:71: warning: type defaults to ‘int’ in declaration of ‘ppc_process_elf_notes’
ppc.c: In function ‘ppc_init’:
ppc.c:85: warning: assignment from incompatible pointer type
cc -c -g -DPPC -m32 -D_FILE_OFFSET_BITS=64 -fPIC -DGDB_7_3_1 netdump.c -Wall -O2 -Wstrict-prototypes -Wmissing-prototypes -fstack-protector
cc -c -g -DPPC -m32 -D_FILE_OFFSET_BITS=64 -fPIC -DGDB_7_3_1 diskdump.c -Wall -O2 -Wstrict-prototypes -Wmissing-prototypes -fstack-protector
diskdump.c:276: warning: no previous prototype for ‘ppc_process_elf_notes’
diskdump.c: In function ‘ppc_process_elf_notes’:
diskdump.c:279: warning: ‘len’ may be used uninitialized in this function
I don't feel comfortable accepting this piece as is -- can you restrict it
to just PPC?:
I could add a '#ifdef PPC' to restrict it. We cannot move ppc_process_elf_notes to ppc.c, as
it requires the diskdump_data details.
I will respin the patches with the sufficient changes.
Thanks
Suzuki
--- a/netdump.c
+++ b/netdump.c
@@ -1696,6 +1696,8 @@ dump_Elf32_Nhdr(Elf32_Off offset, int store)
}
}
}
+ if (nd->num_prstatus_notes> 0)
+ pc->flags2 |= ELF_NOTES;
break;
case NT_PRPSINFO:
netdump_print("(NT_PRPSINFO)\n");
Dave
--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/crash-utility
