----- Original Message ----- > Hi Dave, > > The firmware assisted dump (fadump) patches are still under discussion. When > fadump patches gets into upstream kernel, this change will need to go into > crash. For now, I am posting this patch for a review. > > Reference: > http://lists.ozlabs.org/pipermail/linuxppc-dev/2011-December/094859.html > > Thanks, > -Mahesh. This patch looks good -- the only thing I would change is this section: > @@ -6508,6 +6515,10 @@ clear_active_set(void) > strstr(buf, " .crash_kexec+")) { \ > crash_kexec_task = task; \ > } \ > + if (strstr(buf, " crash_fadump+") || \ > + strstr(buf, " .crash_fadump+")) { \ > + crash_fadump_task = task; \ > + } \ > if (strstr(buf, " machine_kexec+") || \ > strstr(buf, " .machine_kexec+")) { \ > crash_kexec_task = task; \ There should be no need to check for a " crash_fadump+" string on ppc64, correct? In other words, it should be: + if (strstr(buf, " .crash_fadump+")) \ + crash_fadump_task = task; \ Dave -- Crash-utility mailing list Crash-utility@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/crash-utility
