On Tue, Oct 04, 2011 at 11:04:17AM -0400, Nick Bowler wrote:
> On 2011-10-03 13:02 +0530, K.Prasad wrote:
> > diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
> > index 08363b0..483b2fc 100644
> > --- a/arch/x86/kernel/cpu/mcheck/mce.c
> > +++ b/arch/x86/kernel/cpu/mcheck/mce.c
> > @@ -238,6 +238,34 @@ static atomic_t mce_paniced;
> > static int fake_panic;
> > static atomic_t mce_fake_paniced;
> >
> > +void arch_add_nocoredump_note(u32 *buf)
> > +{
> > + struct elf_note note;
> > + const char note_name[] = "PANIC_MCE";
>
> static const ...
>
> > + const char desc_msg[] = "Crash induced due to a fatal machine "
> > + "check error";
>
> likewise.
>
Not sure why you wanted them to be defined as static. These strings are
going to be copied into respective elf-note buffers just a few lines
below their definitions.
> Please don't break string literals onto multiple lines like this, since
> it prevents users from finding the string using "grep".
We could do so, hoping that checkpatch.pl doesn't complain if we crossed
the 80-column width :-)
Thanks,
K.Prasad
--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/crash-utility
