----- Original Message ----- > Hello Dave, > > Thanks for reviewing. I've reflected your comments and this is the > second version. > > About sample vmcores, I'll send email to you in private. > Please wait for a while. > > Change Log > > v0 => v1) > > * Move REMOTE_DAEMON bit from pc->flags to pc->flags2; See PATCH > 01. SADUMP bit is now introduced in pc->flags. > > * Fix the bug, I found locally, that in per_cpu_ptr(), symbol > value of symbol __per_cpu_offset was directly used. Here should > have dereferenced the symbol value. Hello Daisuke, Except for these 3 issues (which I will fix), the second patch looks good: (1) I'll fix this bug in the sadump_cleanup_sadump_data() function: + pc->flags2 &= ~SADUMP; (2) I'll add SADUMP bit display in dump_program_context() for "help -p" (3) I'll add percpu_data size display in dump_offset_table() for "help -o" With those 3 adjustments, the patch is queued for crash-5.1.8. Thanks, Dave -- Crash-utility mailing list Crash-utility@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/crash-utility
