----- "Sharyathi Nagesh" <sharyath@xxxxxxxxxx> wrote:
> Dave
> >
> > Actually, at a minimum, I should change this:
> >
> > if (!symbol_exists("pci_devices")) error(FATAL, "no PCI devices found
> > on this system.\n");
> >
> > to the generic option_not_supported() message.
>
> Can you accept this change I basically replaced above error message to
> option_not_supported() call.
> Do let me know your observation
> Thanks
> Sharyathi N
Hi Sharyathi,
The patch that I already have queued is attached:
- Fix the error message for the "dev -p" comand when run on 2.6.26
or later kernels, which no longer have the global "pci_devices"
list head. The patch changes the message to show "dev: -p option
not supported or applicable on this architecture or kernel", instead
of the misleading "dev: no PCI devices found on this system" message.
(anderson@xxxxxxxxxx)
Thanks,
DaveIndex: dev.c
===================================================================
RCS file: /nfs/projects/cvs/crash/dev.c,v
retrieving revision 1.23
retrieving revision 1.24
diff -u -r1.23 -r1.24
--- dev.c 14 Sep 2009 20:14:30 -0000 1.23
+++ dev.c 23 Apr 2010 14:57:40 -0000 1.24
@@ -100,7 +100,8 @@
return;
case 'p':
- if (machine_type("S390X"))
+ if (machine_type("S390X") ||
+ (THIS_KERNEL_VERSION >= LINUX(2,6,26)))
option_not_supported(c);
do_pci();
return;
--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/crash-utility
