Thanks for the reply Dave.
Even I feel it is better to change the error message to what you have
suggested. That is simplest way to address the issue as well. It gives a
clearer message to the user.
I am curious to hear from Bud on the alternate scheme and progress
as well. Bud your views ?
Thanks
Sharyathi
On 04/23/2010 08:01 PM, Dave Anderson wrote:
>
> ----- "Dave Anderson" <anderson@xxxxxxxxxx> wrote:
>
>>> With this I wanted to know, if you intend to keep dev -p behavior
>>> as it is now or there is any plan to change it to display actual
>>> values?
>>>
>>> Thank You Sharyathi N
>>
>> I (personally) have no plans to change it. If I remember
>> correctly, Bud Brown came up with an alternate scheme, but the
>> imported data from the kernel proper required to accomplish it was
>> enormous (bordering on absurd), so I suggested that it would be
>> more appropriate as an extension module.
>>
>> Bud -- feel free to chime in here... ;-)
>>
>> For that matter, even the "old" way required the import of ~1000
>> lines of kernel #define's -- which always bugged me -- and was
>> pretty much the only crash command that had to do such a thing.
>>
>> Dave
>
> Actually, at a minimum, I should change this:
>
> if (!symbol_exists("pci_devices")) error(FATAL, "no PCI devices found
> on this system.\n");
>
> to the generic option_not_supported() message.
>
> Dave
--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/crash-utility
