[patch]Crash can't process xen dump core files larger that 4GB.

[xiaowei hu <xiaowei.hu@xxxxxxxxxx>]

Hi all,

There is a bug when using crash to process the xen domU dump core that
larger that 4GB(it is found at processing a 10GB guest core dump file).
crash reporting this errors:
crash: cannot find mfn 8392757 (0x801035) in page index                 

crash: cannot read/find cr3 page

this is caused by a var overflow,in the structure of 
typedef struct xc_core_header { 
     unsigned int xch_magic; 
     unsigned int xch_nr_vcpus; 
     unsigned int xch_nr_pages; 
     unsigned int xch_ctxt_offset; 
     unsigned int xch_index_offset; 
     unsigned int xch_pages_offset; 
} xc_core_header_t;

the xch_ctxt_offset,xch_index_offset and xch_pages_offset mean the
offsets in the core dump file , when it is defined as unsingend
long ,that means the file can't be more that 4GB,so when processing with
core dump files that more than 4GB may have error (I encountered
overflow on that 10GB file),so changing those offset vars to unsigned
long ,make sure crash can seek to the right position.
btw,please reply directly to me ,I am not in the mail list.


Signed-off-by: Xiaowei Hu <xiaowei.hu@xxxxxxxxxx>




diff -up crash-5.0.0/xendump.h.org crash-5.0.0/xendump.h
--- crash-5.0.0/xendump.h.org	2010-02-04 03:48:04.000000000 +0800
+++ crash-5.0.0/xendump.h	2010-02-04 05:41:27.000000000 +0800
@@ -28,9 +28,9 @@ typedef struct xc_core_header {
     unsigned int xch_magic;
     unsigned int xch_nr_vcpus;
     unsigned int xch_nr_pages;
-    unsigned int xch_ctxt_offset;
-    unsigned int xch_index_offset;
-    unsigned int xch_pages_offset;
+    unsigned long xch_ctxt_offset;
+    unsigned long xch_index_offset;
+    unsigned long xch_pages_offset;
 } xc_core_header_t;
 
 struct pfn_offset_cache {

--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/crash-utility