On Thu, Jun 11, 2009 at 10:47:49AM -0400, Dave Anderson wrote:
>
> ----- "Dave Anderson" <anderson@xxxxxxxxxx> wrote:
>
> > ----- "Wei Jiang" <talk90091e@xxxxxxxxx> wrote:
> ...
> > > So this line
> > > 140 nr_cpus = (hdr_size - offset) / sizeof(dump_CPU_info_t);
> > >
> > > would not get a correct nr_cpus due to the sizeof().
> > >
> > > A patch to fix this problem as below.
> >
> > BTW, what exactly are the ramifications without the patch -- does the
> > crash session die during initialization? How come nobody ran into
> > this issue given that the code has been in place for almost 2 years?
>
> Again -- what actually happens as a result of the incorrect nr_cpus calculation?
>
In my test, I did not see any exceptions else due to my 32bits dump
file is corrupted. As you know, a incorrect nr_cpus will
lead to some following fields(dha_smp_current_task, dha_stack) are
pointed to a error location, which might be a potential defect and
will be raised in future.
Wei
> I need something to put in the crash.changelog.
>
> Dave
--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/crash-utility
