Re: [PATCH] Add support for 'foreign' page sizes in kdump dumps

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



----- "Bernhard Walle" <bwalle@xxxxxxx> wrote:

> * Dave Anderson [2009-01-14 16:17]:
...
> 
> > (5) Minor nit -- I'd just as soon leave any changes to ia64_init_hyper() to its
> >     maintainer, especially since it makes no sense to make a follow-up call to
> >     ia64_check_adjust_pagesize().     
> 
> Done.
> 
> 
>     Bernhard

I may be preceeding your next response, and I apologize if I am,
but the more I think of it, the more I think that ia64.c should 
just be left as is.  If the kdump (compressed or not) advertises
a page size that's incompatible with the vmlinux file (via the
empty_zero_page check) then the user must be using the wrong vmlinux
file, and the session attempt should just be aborted as is done now.

I can't think of a reason where resetting the page size to conflict
with the dumpfile could ever possibly work?

Dave


--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/crash-utility

[Index of Archives]     [Fedora Development]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]

 

Powered by Linux