* Dave Anderson [2009-01-14 14:08]:
>
> Unlike Robin's patch, your patch to read_dump_header() drops this error check:
>
> if (sizeof(*header) + sizeof(void *) * header->nr_cpus > block_size ||
> header->nr_cpus <= 0) {
> error(INFO, "%s: invalid nr_cpus value: %d\n",
> DISKDUMP_VALID() ? "diskdump" : "compressed kdump",
> header->nr_cpus);
> goto err;
> }
>
> I didn't write this, but it seems to be a valid check. Did you determine
> that it's impossible even though crash does allow 4096 cpus for ia64?
> Or is it a bogus to begin with?
No it's just wrong. Fixed in the next version of the patch. Thanks for
catching this.
Bernhard
--
Bernhard Walle, SUSE Linux Products GmbH, Architecture Development
--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/crash-utility
