Re: [PATCH] Increase limit for get_syment_array() call to 400

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



----- "Bernhard Walle" <bwalle@xxxxxxx> wrote:

> Because s390 kernel System.map contains symbols that repeat very often
> 
>     grep -c 'L2^B1$' System.map-2.6.27.7-4-default
>     276
> 
> this patch increases the limit in the get_syment_array() call from
> 200 to 400. This is a workaround.
> 
> Andreas Krebbel already worked to resolve the problem in binutils which prevents
> that symbols from being included in System.map.
> http://sourceware.org/ml/binutils/2009-01/msg00181.html
> 
> However, since there are kernels (all 2.6.28 at least) out that contain that
> problem, we should also workaround that in crash in my opinion.
> 
> 
> Signed-off-by: Bernhard Walle <bwalle@xxxxxxx>
> 
> 
> 1 file changed, 2 insertions(+), 2 deletions(-)
> symbols.c |    4 ++--

I don't like this patch, mainly because it's a waste of space to even
accept those types of symbols in the first place.  

Instead they should be recognized and rejected in the s390_verify_symbol()
and s390x_verify_symbol() functions.

Dave

--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/crash-utility

[Index of Archives]     [Fedora Development]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]

 

Powered by Linux