Re: when tracking full slabs, check kmem_cache flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dave,
Thanks for reviewing.

> For 2.6.22 only, kmem_cache_node.full is always there, so in that
> case, the SLAB_STORE_USER flag would never get checked above, and
> the full slab would be shown as "(empty)".
> 
> And for 2.6.23 kernels and above, the SLAB_STORE_USER flag
> would *only* be checked if CONFIG_SLUB_DEBUG was *not* set.
> And if CONFIG_SLUB_DEBUG is not set, then full slabs would not
> be tracked because add_full() is a no-op -- regardless whether
> the SLAB_STORE_USER flag was set or not.
> 
> Shouldn't it be "||" instead of "&&"?

Right. I have attached the modified patch.

Itaru

Attachment: store_user-flagcheck.patch
Description: Binary data

--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/crash-utility

[Index of Archives]     [Fedora Development]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]

 

Powered by Linux