Re: crash version 4.0-4.7 is available

[Luc Chouinard <lucchouina@xxxxxxxxx>]

Yes, let's use __ia64__ for uniformity.
I'll patch it in.

   Luc

----- Original Message ----
From: Dave Anderson <anderson@xxxxxxxxxx>
To: holzheu@xxxxxxxxxxxxxxxxxx; "Discussion list for crash utility usage, maintenance and development" <crash-utility@xxxxxxxxxx>; lucchouina@xxxxxxxxx
Sent: Wednesday, September 26, 2007 11:57:37 AM
Subject: Re: crash version 4.0-4.7 is available

Michael Holzheu wrote:
> On Wed, 2007-09-26 at 10:03 -0400, Dave Anderson wrote:
>
>>Any results on or s390/s390x?
>
>
> Great to have sial in crash! On s390/s390x it compiles with the
> following patch:
>

Michael, thanks for the test and patch.

Luc, this one is also looks OK, but maybe the ia64 patch
should use __ia64__, which is what the crash utility code
itself depends upon?

Thanks,
   Dave

> ---
>
> diff -Naurp crash-4.0-4.7/extensions/libsial/sial_api.h crash-4.0-4.7-sial-fix-s390/extensions/libsial/sial_api.h
> --- crash-4.0-4.7/extensions/libsial/sial_api.h    2007-09-25 17:01:56.000000000 +0200
> +++ crash-4.0-4.7-sial-fix-s390/extensions/libsial/sial_api.h    2007-09-26 17:30:58.000000000 +0200
> @@ -13,6 +13,8 @@
>  #define ABI_MIPS    1
>  #define ABI_INTEL_X86    2
>  #define ABI_INTEL_IA    3
> +#define ABI_S390    4
> +#define ABI_S390X    5
>  
>  /* types of variables */
>  #define V_BASE          1
> diff -Naurp crash-4.0-4.7/extensions/sial.c crash-4.0-4.7-sial-fix-s390/extensions/sial.c
> --- crash-4.0-4.7/extensions/sial.c    2007-09-25 17:01:56.000000000 +0200
> +++ crash-4.0-4.7-sial-fix-s390/extensions/sial.c    2007-09-26 17:31:05.000000000 +0200
> @@ -807,17 +807,25 @@ _init() /* Register the command set. */
>          /* set api, default size, and default sign for types */
>  #ifdef i386
>  #define SIAL_ABI  ABI_INTEL_X86
> -#else
> +#else
>  #ifdef ia64
>  #define SIAL_ABI  ABI_INTEL_IA
>  #else
>  #ifdef __x86_64__
>  #define SIAL_ABI  ABI_INTEL_IA
>  #else
> +#ifdef __s390__
> +#define SIAL_ABI  ABI_S390
> +#else
> +#ifdef __s390x__
> +#define SIAL_ABI  ABI_S390X
> +#else
>  #error sial: Unkown ABI
>  #endif
>  #endif
>  #endif
> +#endif
> +#endif
>          sial_apiset(&icops, SIAL_ABI, sizeof(long), 0);
>  
>          sial_version();
>
>

---

Luggage? GPS? Comic books? 
Check out fitting  gifts for grads at Yahoo! Search.
--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/crash-utility