* Dave Anderson <anderson@xxxxxxxxxx> [2007-09-26 16:03]:
> Bernhard Walle wrote:
>> * Dave Anderson <anderson@xxxxxxxxxx> [2007-09-25 21:58]:
>>> - Incorporation of Luc Chouinard's SIAL interpreter (Simple Image
>>> Access Language) as a crash extension module. When loaded with
>>> the "extend" command, the sial.so module provides three commands,
>>> "load" to load a SIAL script, "unload" to unload it, and "edit",
>>> which unloads the script, brings up an $EDITOR-based edit session
>>> of the script, and then loads it again. Also, when the sial.so
>>> module is loaded, it will automatically load any SIAL scripts
>>> found in the /usr/share/sial/crash or $HOME/.sial directories.
>>> Therefore, by putting "extend <path-to>/sial.so" in either
>>> ./.crashrc or $HOME/.crashrc, all desired SIAL scripts may be
>>> loaded on a particular machine in a hands-off manner. For details,
>>> consult the README and README.sial files in the extensions/libsial
>>> subdirectory. (lucchouina@xxxxxxxxx)
>> This extension does not build on IA64 although it should. Patch:
>> ---
>> extensions/sial.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> --- a/extensions/sial.c
>> +++ b/extensions/sial.c
>> @@ -808,7 +808,7 @@ _init() /* Register the command set. */
>> #ifdef i386
>> #define SIAL_ABI ABI_INTEL_X86
>> #else -#ifdef ia64
>> +#ifdef __ia64
>> #define SIAL_ABI ABI_INTEL_IA
>> #else
>> #ifdef __x86_64__
>
>
> Hmmm, I wonder about this part, earlier in sial.c on line 489?
>
> #ifdef ia64
> {"ia64", "1"},
> {"__ia64", "1"},
> {"__ia64__", "1"},
> {"__LP64__", "1"},
> {"_LONGLONG", "1"},
> {"__LONG_MAX__", "9223372036854775807L"},
> #endif
Right, I didn't actually run the code, I only built the code. ;)
> Any results on or s390/s390x? And is this even
> supposed to support ppc64?
That doesn't build at all:
817 #error sial: Unkown ABI
Thanks,
Bernhard
Updated patch:
---
extensions/sial.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/extensions/sial.c
+++ b/extensions/sial.c
@@ -486,7 +486,7 @@ struct linuxdefs_s {
{"__s390x", "1"},
{"__s390x__", "1"},
#endif
-#ifdef ia64
+#ifdef __ia64
{"ia64", "1"},
{"__ia64", "1"},
{"__ia64__", "1"},
@@ -808,7 +808,7 @@ _init() /* Register the command set. */
#ifdef i386
#define SIAL_ABI ABI_INTEL_X86
#else
-#ifdef ia64
+#ifdef __ia64
#define SIAL_ABI ABI_INTEL_IA
#else
#ifdef __x86_64__
--
Crash-utility mailing list
Crash-utility@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/crash-utility
