On 12/15/05 08:45, Troy Heber wrote: > On 12/15/05 09:09, Dave Anderson wrote: > > > > I don't think that the "else" part is required since lkcd_offset_to_first_page > > is statically initialized to LKCD_OFFSET_TO_FIRST_PAGE above. But > > for readability this looks fine to me. > > > > It's not the initialization that's the problem, it's the unconditional > assignment of dh_dump_buffer_size in hunk 2 of the patch. That > assignment has to be conditional on the dump version. Doha.. I see what your saying now. Yes, I added the else for readibility, feel free to nuke it if you want. Troy
