Badari Pulavarty wrote: > > > Let me run crash tool on RHEL4 vmcore (I believe, I saved vmlinux and > > vmcore created on RHEL4 kernel). Yes, it should support backward > > compatible since we did not change the previous code patch even though > > we should be having one vtop with the new approach. But, we will check > > on previous vmcore or on live RHEL4 kernel. > > No. We still we have 2 vtop() functions. One for old kernels (pre-4level > changes - which also works on 2.4 kernels). Other for kernels with > 4-level pagetables, 64K page support. > Actually I'd *much* prefer that the old vtop be left in place, because the old one support both RHEL3 and RHEL4 kernels, covering my ass nicely... ;-) > > I guess, make a single vtop() which works on all kernels: 2.4 kernels, > 2.6 pre-level4 changes, 4-level pagetables changes, 64k pagesupport etc. > But I really don't have bandwidth to understand all the shifts and > masks, make changes to incorporate all of differences & back and test > every single one of them (I have no interest or time testing 2.4 > kernels). > I agree -- it's not a big deal that there are 2 vtop functions. Dave
