Re: [PATCH v2 62/88] ASoC: intel: catpt: Convert to RUNTIME_PM_OPS() & co

[Takashi Iwai <tiwai@xxxxxxx>]

On Mon, 17 Mar 2025 11:08:54 +0100,
Cezary Rojewski wrote:
> 
> On 2025-03-17 10:55 AM, Takashi Iwai wrote:
> > Use the newer RUNTIME_PM_OPS() and SYSTEM_SLEEP_PM_OPS() macros
> > instead of SET_RUNTIME_PM_OPS() and SET_SYSTEM_SLEEP_PM_OPS() together
> > with pm_ptr(), which allows us dropping ugly __maybe_unused
> > attributes.
> 
> Off-topic comment:
> While __maybe_unused may not be the prettiest, it is still better
> alternative than #if/ifdef spam all over the code if you ask me.

Yeah, that's why we introduced it in the past.

The downside is it's often more cumbersome to rip it off than the
explicit ifdef.


thanks,

Takashi