Re: [PATCH v1 1/1] ASoC: SOF: ipc4-topology: Allocate ref_params on stack

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Thu, Mar 13, 2025 at 01:21:17PM +0200, Péter Ujfalusi wrote:
> On 12/03/2025 18:05, Andy Shevchenko wrote:
> > Currently the compiler (clang 19.1.7) is not happy about the size of
> > the stack frame in sof_ipc4_prepare_copier_module:
> > 
> > sound/soc/sof/ipc4-topology.c:1800:1: error: stack frame size (1288) exceeds limit (1024) in 'sof_ipc4_prepare_copier_module' [-Werror,-Wframe-larger-than]
> >  1800 | sof_ipc4_prepare_copier_module(struct snd_sof_widget *swidget,
> >       | ^
> > 
> > Work around this by allocating ref_params on stack, as it looks the biggest
> > variable on stack right now.
> > 
> > Note, this only happens when compile for 32-bit machines (x86_32 in my case).
> 
> I don't have better idea for fix, apart from somehow refactor this huge
> function.
> Thank you for the fix,
> 
> Acked-by: Peter Ujfalusi <peter.ujfalusi@xxxxxxxxxxxxxxx>

Thank you for looking into it!

-- 
With Best Regards,
Andy Shevchenko