Hi,
On Tue, Mar 04, 2025 at 08:39:11PM +0100, Stefan Wahren wrote:
> drm_atomic_helper_connector_hdmi_hotplug() must be called
> regardless of the connection status, otherwise the HDMI audio
> disconnect event won't be notified.
>
> Fixes: 2ea9ec5d2c20 ("drm/vc4: hdmi: use drm_atomic_helper_connector_hdmi_hotplug()")
> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> Signed-off-by: Stefan Wahren <wahrenst@xxxxxxx>
The patch makes sense to me, but I think we should also update the
documentation of drm_atomic_helper_connector_hdmi_hotplug to make it
clearer it needs to be called on any status update.
Maxime
Attachment:
signature.asc
Description: PGP signature
- References:
- [PATCH V2 0/2] drm/vc4: hdmi: Add jack detection to HDMI audio driver
- From: Stefan Wahren
- [PATCH V2 1/2] drm/vc4: hdmi: Call HDMI hotplug helper on disconnect
- From: Stefan Wahren
- [PATCH V2 0/2] drm/vc4: hdmi: Add jack detection to HDMI audio driver
- Prev by Date: [PATCH 8/8] ASoC: SOF: Intel: ptl: Add support for mic privacy
- Next by Date: Re: [PATCH V2 2/2] drm/vc4: hdmi: Add jack detection to HDMI audio driver
- Previous by thread: [PATCH V2 1/2] drm/vc4: hdmi: Call HDMI hotplug helper on disconnect
- Next by thread: [PATCH V2 2/2] drm/vc4: hdmi: Add jack detection to HDMI audio driver
- Index(es):
 |