Re: [PATCH v2] ASoC: ops: Consistently treat platform_max as control value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Fri, 28 Feb 2025 15:14:56 +0000, Charles Keepax wrote:
> This reverts commit 9bdd10d57a88 ("ASoC: ops: Shift tested values in
> snd_soc_put_volsw() by +min"), and makes some additional related
> updates.
> 
> There are two ways the platform_max could be interpreted; the maximum
> register value, or the maximum value the control can be set to. The
> patch moved from treating the value as a control value to a register
> one. When the patch was applied it was technically correct as
> snd_soc_limit_volume() also used the register interpretation. However,
> even then most of the other usages treated platform_max as a
> control value, and snd_soc_limit_volume() has since been updated to
> also do so in commit fb9ad24485087 ("ASoC: ops: add correct range
> check for limiting volume"). That patch however, missed updating
> snd_soc_put_volsw() back to the control interpretation, and fixing
> snd_soc_info_volsw_range(). The control interpretation makes more
> sense as limiting is typically done from the machine driver, so it is
> appropriate to use the customer facing representation rather than the
> internal codec representation. Update all the code to consistently use
> this interpretation of platform_max.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: ops: Consistently treat platform_max as control value
      commit: 0eba2a7e858907a746ba69cd002eb9eb4dbd7bf3

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark





[Index of Archives]     [Pulseaudio]     [Linux Audio Users]     [ALSA Devel]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux