Re: [PATCH] snd: hda: realtek: fix incorrect IS_REACHABLE() usage

["Arnd Bergmann" <arnd@xxxxxxxx>]

On Tue, Mar 4, 2025, at 15:43, Takashi Iwai wrote:
> On Tue, 04 Mar 2025 15:25:55 +0100,
>
> Thanks for the patch.  Indeed it's a very corner case, but I still
> hesitate to add a kconfig dependency.  Can we take an alternative fix
> to define the proper dummy functions like below instead?

I'm sure that works, and I had considered something like that,
but I really dislike the IS_REACHABLE() use because I think it
causes more problems than it solves. (I introduced the macro
originally but regret that).

Note that the only way to disable input is to have manually flip
CONFIG_EXPERT and CONFIG_TTY as well as the major GPU drivers
that select it:

config INPUT
        tristate "Generic input layer (needed for keyboard, mouse, ...)" if EXPERT
        default y

so in the end, there is very little difference between
your patch and mine, as they both fix build testing on
randconfig.

    Arnd