Re: [PATCH v3 15/20] ASoC: tas2764: Enable main IRQs

[Mark Brown <broonie@xxxxxxxxxx>]

On Fri, Feb 28, 2025 at 07:58:33AM +1000, James Calligeros wrote:
> On Fri, Feb 28, 2025 at 2:23 AM Mark Brown <broonie@xxxxxxxxxx> wrote:
> > On Thu, Feb 27, 2025 at 10:07:42PM +1000, James Calligeros wrote:

> > > IRQ handling was added in commit dae191fb957f ("ASoC: tas2764: Add IRQ
> > > handling") however that same commit masks all interrupts coming from
> > > the chip. Unmask the "main" interrupts so that we can see and
> > > deal with a number of errors including clock, voltage, and current.

> > Shouldn't this also be a fix?

> I don't think so. The referenced commit only says that it adds an IRQ handler.
> I don't think this commit is actually "fixing" anything - it's just
> enabling previously
> masked interrupts.

I think the expectation would be that when the interrupt handler was
added it would've been possible for it to fire.

Attachment: signature.asc
Description: PGP signature