Re: [PATCH] ASoC: ops: Revert addition of min whilst checking platform max

[Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>]

On Thu, Feb 27, 2025 at 02:35:13PM +0000, Charles Keepax wrote:
> This reverts commit 9bdd10d57a88 ("ASoC: ops: Shift tested values in
> snd_soc_put_volsw() by +min").
> 
> There are two ways the platform_max could be interpreted; the maximum
> register value, or the maximum value the control can be set to. The
> patch moved from treating the value as a control value to a register
> one. When the patch was applied it was technically correct as
> snd_soc_limit_volume() also used the register interpretation. However,
> even then all the other usages treated platform_max as a control
> value, and snd_soc_limit_volume() has since been updated to also
> do so in commit fb9ad24485087 ("ASoC: ops: add correct range
> check for limiting volume"). That patch however, missed updating
> snd_soc_put_volsw() back to the control interpretation. The control
> interpretation makes more sense as limiting is typically done from
> the machine driver, so it is appropriate to use the customer facing
> representation rather than the internal codec representation.
> 

Seems there is also one other case in snd_soc_info_volsw_range
than needs fixed will do a v2 and resend.

Thanks,
Charles