Re: [PATCH 24/24] ASoC: codecs: rt5682s: Update definition of device_id tables

[Cezary Rojewski <cezary.rojewski@xxxxxxxxx>]

On 2025-02-21 3:08 AM, Shuming [范書銘] wrote:
> > Follow PCI-based format (10ECxxxx) for ACPI IDs by adding relevant entries to
> > the existing table.
> >
> > While at it, there shall be no comma after the terminator entry and initializing
> > fields with 0 for statically defined structs is redundant.
> >
> > Signed-off-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx>
> > ---
> >   sound/soc/codecs/rt5682s.c | 7 ++++---
> >   1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/sound/soc/codecs/rt5682s.c b/sound/soc/codecs/rt5682s.c index
> > ce2e88e066f3..5ad0cc3fab7f 100644
> > --- a/sound/soc/codecs/rt5682s.c
> > +++ b/sound/soc/codecs/rt5682s.c
> > @@ -3310,13 +3310,14 @@ static void rt5682s_i2c_remove(struct i2c_client
> > *client)
> >
> >   static const struct of_device_id rt5682s_of_match[] = {
> >          {.compatible = "realtek,rt5682s"},
> > -       {},
> > +       {}
> >   };
> >   MODULE_DEVICE_TABLE(of, rt5682s_of_match);
> >
> >   static const struct acpi_device_id rt5682s_acpi_match[] = {
> > -       {"RTL5682", 0,},
> > -       {},
> > +       { "RTL5682" },
> > +       { "10EC5682" },
> > +       {}
>
> The rt5682s and rt5682 are different codec drivers.
> The rt5682s uses RTL5682 APCI ID and rt5682 uses 10EC5682.


Sorry for the delay in my response. Thank you for the review, Shuming!

I have similar thoughts as for patch 20/24 and rt1015p case, reviewed by 
Chiou. To not dilute the subject too much, I'd suggest continue the 
"confusing IDs" discussion there. For v2, this patch will be removed to 
not block the merge.

Kind regards,
Czarek