Re: [PATCH] ASoC: dapm-graph: set fill colour of turned on nodes

[Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>]

Hello Nicolas,

+Cc: Mark Brown

On Fri, 21 Feb 2025 21:39:32 +0100
Nicolas Frattaroli <nicolas.frattaroli@xxxxxxxxxxxxx> wrote:

> Some tools like KGraphViewer interpret the "ON" nodes not having an
> explicitly set fill colour as them being entirely black, which obscures
> the text on them and looks funny. In fact, I thought they were off for
> the longest time. Comparing to the output of the `dot` tool, I assume
> they are supposed to be white.
> 
> Instead of speclawyering over who's in the wrong and must immediately
> atone for their wickedness at the altar of RFC2119, just be explicit
> about it, set the fillcolor to white, and nobody gets confused.
> 
> Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@xxxxxxxxxxxxx>
> ---
> This is somewhat "just thrown out there"; I noticed that not setting the
> fill colour breaks KGraphViewer only *after* I thought this was just how
> they were for several days. With this change, both dot and KGraphViewer
> render it correctly, but I have no clue as to whether it's in the spirit
> of the file format at all. I figure that if this saves some other poor
> souls a bit of time and confusion, then it's worth it.

I confirm the issue with a plain installation of KGraphViewer (which I
didn't know at all before -- interesting tool).

So, let's have mercy on the poor souls:

Tested-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>
Reviewed-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com