Re: [PATCH 4/6] ASoC: mediatek: mt8188: Support DMIC in AFE

[AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>]

Il 19/02/25 14:40, Nícolas F. R. A. Prado ha scritto:
> On Wed, Feb 19, 2025 at 12:29:13PM +0100, AngeloGioacchino Del Regno wrote:
> > Il 18/02/25 21:52, Nícolas F. R. A. Prado ha scritto:
> > > From: parkeryang <Parker.Yang@xxxxxxxxxxxx>
> > >
> > > Add the AFE routes that connect the DMIC (I004-I011) to the UL9 frontend
> > > (O002-O009) and register the mt8188-dmic DAI driver during probe.
> > >
> > > Signed-off-by: parkeryang <Parker.Yang@xxxxxxxxxxxx>
> > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx>
> > > ---
> > >    sound/soc/mediatek/mt8188/Makefile            |  1 +
> > >    sound/soc/mediatek/mt8188/mt8188-afe-common.h |  1 +
> > >    sound/soc/mediatek/mt8188/mt8188-afe-pcm.c    | 24 ++++++++++++++++++++++++
> > >    3 files changed, 26 insertions(+)
> > >
> > > diff --git a/sound/soc/mediatek/mt8188/Makefile b/sound/soc/mediatek/mt8188/Makefile
> > > index 1178bce45c50ba252672a32b3877732a5a76c610..b9f3e4ad7b07ba9e21c846706371c53269f894db 100644
> > > --- a/sound/soc/mediatek/mt8188/Makefile
> > > +++ b/sound/soc/mediatek/mt8188/Makefile
> > > @@ -6,6 +6,7 @@ snd-soc-mt8188-afe-y := \
> > >    	mt8188-afe-pcm.o \
> > >    	mt8188-audsys-clk.o \
> > >    	mt8188-dai-adda.o \
> > > +	mt8188-dai-dmic.o \
> > >    	mt8188-dai-etdm.o \
> > >    	mt8188-dai-pcm.o
> >
> > The Makefile addition doesn't belong to this commit. Please fix.
>
> I was divided between adding it here or in the previous commit that adds the
> dmic driver. Only in this commit is the mt8188_dai_dmic_register() added, so
> this is the first commit in which any of the code from the dmic driver is
> actually used, hence why I added it here. But adding the makefile entry together
> with the driver code, even if it's not used, makes sense too, so I'll move it
> there.

You can even squash the two commits... after all, adding a piece that doesn't
get used until a later time is practically useless... right?! :-)