On Tue, Feb 18, 2025 at 06:35:58PM +1000, James Calligeros wrote: > From: Hector Martin <marcan@xxxxxxxxx> > > Multiple amps can be connected to the same SDZ GPIO. Using raw GPIOs for > this breaks, as there is no concept of refcounting/sharing. In order to > model these platforms, introduce support for an SDZ "regulator". This > allows us to represent the SDZ GPIO as a simple regulator-fixed, and > then the regulator core takes care of refcounting so that all codecs are > only powered down once all the driver instances are in the suspend > state. Same issue with the use of the regulator API winding up as ABI here as with the earlier patch - I get why you're doing this pragmatically and we should just have a general helper for refcounted GPIO enables.
Attachment:
signature.asc
Description: PGP signature
- References:
- [PATCH v2 00/29] ASoC: tas27{64,70}: improve support for Apple codec variants
- From: James Calligeros
- [PATCH v2 24/29] ASoC: tas2770: Add SDZ regulator
- From: James Calligeros
- [PATCH v2 00/29] ASoC: tas27{64,70}: improve support for Apple codec variants
- Prev by Date: Re: [PATCH v2 26/29] ASoC: tas2770: Add zero-fill and pull-down controls
- Next by Date: Re: [PATCH v2 28/29] ASoC: tas2764: Set the SDOUT polarity correctly
- Previous by thread: [PATCH v2 24/29] ASoC: tas2770: Add SDZ regulator
- Next by thread: [PATCH v2 25/29] ASoC: tas2770: Power cycle amp on ISENSE/VSENSE change
- Index(es):
![]() |