Re: [PATCH] ALSA: hda/conexant: Add quirk for HP ProBook 450 G4 mute LED

[John Veness <john-linux@xxxxxxxxxxxxx>]

On 17/02/2025 09:56, Takashi Iwai wrote:
> On Mon, 17 Feb 2025 00:21:57 +0100,
> John Veness wrote:
>>
>> Allows the LED on the dedicated mute button on the HP ProBook 450 G4 laptop
>> to change colour correctly.
>>
>> Signed-off-by: John Veness <john-linux@xxxxxxxxxxxxx>
>> ---
>> I have only tested this with 6.13, but I expect it could be applied to older
>> stable kernels too. The HP ProBook 450 G4 laptop was released in 2017. 
> 
> It's fine to put Cc to stable in the patch, then.
> 
> But, your patch seems inapplicable, likely because your mailer
> converted tabs to spaces.  Could you fix the mailer setup and
> resubmit?

Ah darn it! I think this was a copy-and-paste issue. I'll resubmit with
tabs, and CC stable too. Thanks for the feedback.

John

> thanks,
> 
> Takashi
> 
>>
>>  sound/pci/hda/patch_conexant.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
>> index 4985e72b9..34874039a 100644
>> --- a/sound/pci/hda/patch_conexant.c
>> +++ b/sound/pci/hda/patch_conexant.c
>> @@ -1090,6 +1090,7 @@ static const struct hda_quirk cxt5066_fixups[] = {
>>         SND_PCI_QUIRK(0x103c, 0x814f, "HP ZBook 15u G3", CXT_FIXUP_MUTE_LED_GPIO),
>>         SND_PCI_QUIRK(0x103c, 0x8174, "HP Spectre x360", CXT_FIXUP_HP_SPECTRE),
>>         SND_PCI_QUIRK(0x103c, 0x822e, "HP ProBook 440 G4", CXT_FIXUP_MUTE_LED_GPIO),
>> +       SND_PCI_QUIRK(0x103c, 0x8231, "HP ProBook 450 G4", CXT_FIXUP_MUTE_LED_GPIO),
>>         SND_PCI_QUIRK(0x103c, 0x828c, "HP EliteBook 840 G4", CXT_FIXUP_HP_DOCK),
>>         SND_PCI_QUIRK(0x103c, 0x8299, "HP 800 G3 SFF", CXT_FIXUP_HP_MIC_NO_PRESENCE),
>>         SND_PCI_QUIRK(0x103c, 0x829a, "HP 800 G3 DM", CXT_FIXUP_HP_MIC_NO_PRESENCE),
>> -- 
>> 2.48.1
>>