On Sun, Feb 16, 2025 at 05:58:40PM -0500, Alyssa Rosenzweig wrote: > > config SND_SOC_TAS2764 > > tristate "Texas Instruments TAS2764 Mono Audio amplifier" > > depends on I2C > > + depends on OF > Do we want to drop support for !OF configurations? The alternative would > be extra #ifdef soup. I don't know if this is a useful build configuration but we should be deliberate about adding the depends. If the Apple variants of these chips are making their way into laptops I'd not be surprised if the other variants might appear in x86 laptops too. What's the specific reason for dropping the build coverage, is it actually getting in the way at all? We have lots of drivers which build happily with !OF even if practically speaking they'll never appear on such systems since it helps improve build coverage which makes life easier for people doing general coverage.
Attachment:
signature.asc
Description: PGP signature
- References:
- [PATCH 00/27] ASoC: tas27{64,70}: improve support for Apple codec variants
- From: James Calligeros
- [PATCH 03/27] ASoC: tas2764: Extend driver to SN012776
- From: James Calligeros
- Re: [PATCH 03/27] ASoC: tas2764: Extend driver to SN012776
- From: Alyssa Rosenzweig
- [PATCH 00/27] ASoC: tas27{64,70}: improve support for Apple codec variants
- Prev by Date: [PATCH] ALSA: hda/conexant: Add quirk for HP ProBook 450 G4 mute LED
- Next by Date: Re: [PATCH 11/27] ASoC: tas2770: Export 'die_temp' to sysfs
- Previous by thread: Re: [PATCH 03/27] ASoC: tas2764: Extend driver to SN012776
- Next by thread: [PATCH 07/27] ASoC: tas2764: Reinit cache on part reset
- Index(es):
![]() |