Re: [PATCH] ASoC: Intel: avs: Use str_on_off() in avs_dsp_core_power()

[Cezary Rojewski <cezary.rojewski@xxxxxxxxx>]

On 2025-02-12 10:12 AM, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_on_off() helper function.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>
> ---
>   sound/soc/intel/avs/dsp.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/avs/dsp.c b/sound/soc/intel/avs/dsp.c
> index 7b47e52c2b39..b9de691e9b9b 100644
> --- a/sound/soc/intel/avs/dsp.c
> +++ b/sound/soc/intel/avs/dsp.c
> @@ -6,6 +6,7 @@
>   //          Amadeusz Slawinski <amadeuszx.slawinski@xxxxxxxxxxxxxxx>
>   //
>   
> +#include <linux/string_choices.h>
>   #include <sound/hdaudio_ext.h>
>   #include "avs.h"
>   #include "registers.h"
> @@ -39,7 +40,7 @@ int avs_dsp_core_power(struct avs_dev *adev, u32 core_mask, bool power)
>   				       AVS_ADSPCS_TIMEOUT_US);
>   	if (ret)
>   		dev_err(adev->dev, "core_mask %d power %s failed: %d\n",
> -			core_mask, power ? "on" : "off", ret);
> +			core_mask, str_on_off(power), ret);
>   
>   	return ret;
>   }

LGTM

Reviewed-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx>