On Thu, Feb 06, 2025 at 03:22:39AM +0000, Kuninori Morimoto wrote: > The reason of of_property_read_u32() returns error are > > (A) -EINVAL: if the property does not exist > (B) -ENODATA: if property does not have a value > (C) -EOVERFLOW: if the property data isn't large enough > > Property does not exist (A) is not error in this function. > So, current code returns error if (B) or (C) case. > > But these are handled by "DT checker". We don't need to check it in the > code. Let's remove it We're assuming that people actually run the validation tools, which the reports that Rob sends out from his bot seem to indicate doesn't happen reliably and I'd expect would be even less relaible with out of tree DTs.
Attachment:
signature.asc
Description: PGP signature
- References:
- [PATCH] ASoC: soc-core: remove verbose check from snd_soc_of_parse_tdm_slot()
- From: Kuninori Morimoto
- [PATCH] ASoC: soc-core: remove verbose check from snd_soc_of_parse_tdm_slot()
- Prev by Date: [PATCH] ASoC: SOF: ipc4-pcm: Move out be_rate initialization from for loop in fixup
- Next by Date: [PATCH v6 0/4] Add static channel mapping between soundwire master and slave
- Previous by thread: [PATCH] ASoC: soc-core: remove verbose check from snd_soc_of_parse_tdm_slot()
- Next by thread: [PATCH v2] ASoC: SOF: ipc4-topology: Harden loops for looking up ALH copiers
- Index(es):
![]() |